Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): remove i18next dependency #1135

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Conversation

ecp4224
Copy link
Collaborator

@ecp4224 ecp4224 commented Nov 20, 2024

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Copy link

socket-security bot commented Nov 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@commitlint/cli@17.8.1 None 0 29.8 kB escapedcat
npm/@commitlint/config-conventional@17.8.1 None 0 9.61 kB escapedcat
npm/@commitlint/config-validator@17.8.1 None 0 12.2 kB escapedcat
npm/@commitlint/ensure@17.8.1 None 0 13.6 kB escapedcat
npm/@commitlint/execute-rule@17.8.1 None 0 3.96 kB escapedcat
npm/@commitlint/format@17.8.1 None 0 13.2 kB escapedcat
npm/@commitlint/is-ignored@17.8.1 None 0 9.08 kB escapedcat
npm/@commitlint/lint@17.8.1 None 0 14.6 kB escapedcat
npm/@commitlint/load@17.8.1 environment +1 3.86 MB escapedcat
npm/@commitlint/message@17.8.1 None 0 2.81 kB escapedcat
npm/@commitlint/parse@17.8.1 None 0 4.51 kB escapedcat
npm/@commitlint/read@17.8.1 filesystem 0 12.4 kB escapedcat
npm/@commitlint/resolve-extends@17.8.1 None 0 12.3 kB escapedcat
npm/@commitlint/rules@17.8.1 None 0 83.4 kB escapedcat
npm/@commitlint/to-lines@17.8.1 None 0 2.78 kB escapedcat
npm/@commitlint/top-level@17.8.1 None 0 3.97 kB escapedcat
npm/@commitlint/types@17.8.1 None 0 27.1 kB escapedcat
npm/@metamask/action-utils@1.1.1 filesystem +1 146 kB lgbot
npm/@metamask/auto-changelog@3.4.4 None +1 635 kB metamaskbot
npm/@stencil/core@4.22.2 None 0 21 MB ionicjs
npm/@tsconfig/node10@1.0.11 None 0 2.31 kB typescript-deploys
npm/@types/i18n@0.13.12 None 0 22.1 kB types
npm/@types/minimist@1.2.5 None 0 6.27 kB types
npm/@types/node-fetch@2.6.12 None 0 11.9 kB types
npm/@types/node@18.19.64 None 0 2.03 MB types
npm/@types/readable-stream@4.0.18 None 0 31.7 kB types
npm/@zeit/schemas@2.36.0 None 0 34.1 kB vercel-release-bot
npm/acorn-walk@8.3.4 None 0 52.3 kB marijn
npm/babel-preset-current-node-syntax@1.1.0 eval 0 7.13 kB nicolo-ribaudo
npm/cjs-module-lexer@1.4.1 None 0 146 kB guybedford
npm/cli-cursor@4.0.0 None 0 4.45 kB sindresorhus
npm/cmd-shim@6.0.3 filesystem 0 12.2 kB npm-cli-ops
npm/commander@11.0.0 environment, filesystem, shell 0 176 kB abetomo
npm/conventional-changelog-angular@6.0.0 filesystem 0 13.1 kB oss-bot
npm/conventional-changelog-conventionalcommits@6.1.0 filesystem 0 15.9 kB oss-bot
npm/conventional-commits-parser@4.0.0 None +2 71.4 kB oss-bot
npm/flatted@3.3.2 None 0 33.5 kB webreflection
npm/import-local@3.2.0 None 0 4.73 kB sindresorhus
npm/istanbul-lib-instrument@6.0.3 None 0 72 kB oss-bot
npm/lint-staged@13.3.0 Transitive: environment +3 879 kB okonet
npm/listr2@6.6.1 environment 0 279 kB cenk1cenk2
npm/log-update@5.0.1 None +2 166 kB sindresorhus
npm/openai@4.72.0 environment, network 0 2.73 MB dschnurr-openai
npm/path-to-regexp@3.3.0 None 0 25.8 kB blakeembrey
npm/puppeteer@23.8.0 environment Transitive: filesystem, shell +6 24.8 MB google-wombot
npm/restore-cursor@4.0.0 None 0 3.23 kB sindresorhus
npm/rfdc@1.4.1 None 0 27.1 kB matteo.collina
npm/serve-handler@6.1.6 environment, filesystem +1 75.8 kB vercel-release-bot
npm/serve@14.2.4 None +1 67.2 kB vercel-release-bot
npm/spdx-exceptions@2.5.0 None 0 3.47 kB kemitchell
npm/spdx-license-ids@3.0.20 None 0 13 kB kemitchell, shinnn
npm/table@6.8.2 None 0 335 kB gajus-table
npm/ts-jest@29.2.5 None 0 328 kB anhpnnd, kul, tsjest
npm/v8-to-istanbul@9.3.0 filesystem, unsafe 0 47.6 kB oss-bot

🚮 Removed packages: npm/@babel/compat-data@7.24.9, npm/@babel/core@7.24.9, npm/@babel/generator@7.24.10, npm/@babel/helper-compilation-targets@7.24.8, npm/@babel/helper-module-transforms@7.24.9, npm/@babel/helper-string-parser@7.24.8, npm/@babel/helper-validator-option@7.24.8, npm/@babel/helpers@7.24.8, npm/@babel/parser@7.24.8, npm/@babel/traverse@7.24.8, npm/@commitlint/cli@17.6.7, npm/@commitlint/config-conventional@17.6.7, npm/@commitlint/config-validator@17.6.7, npm/@commitlint/ensure@17.6.7, npm/@commitlint/execute-rule@17.4.0, npm/@commitlint/format@17.4.4, npm/@commitlint/is-ignored@17.6.7, npm/@commitlint/lint@17.6.7, npm/@commitlint/load@17.6.7, npm/@commitlint/message@17.4.2, npm/@commitlint/parse@17.6.7, npm/@commitlint/read@17.5.1, npm/@commitlint/resolve-extends@17.6.7, npm/@commitlint/rules@17.6.7, npm/@commitlint/to-lines@17.4.0, npm/@commitlint/top-level@17.4.0, npm/@commitlint/types@17.4.4, npm/@metamask/action-utils@1.0.0, npm/@metamask/auto-changelog@3.4.3, npm/@scure/base@1.1.1, npm/@types/node-fetch@2.6.9, npm/@types/node@18.19.3, npm/@types/readable-stream@4.0.10, npm/@zeit/schemas@2.29.0, npm/commander@10.0.1, npm/conventional-changelog-angular@5.0.13, npm/conventional-changelog-conventionalcommits@5.0.0, npm/conventional-commits-parser@3.2.4, npm/cosmiconfig@8.2.0, npm/digest-fetch@1.3.0, npm/fast-glob@3.3.0, npm/is-core-module@2.12.1, npm/istanbul-lib-report@3.0.0, npm/istanbul-reports@3.1.5, npm/jest-validate@29.6.3, npm/lint-staged@13.2.3, npm/listr2@5.0.8, npm/log-update@4.0.0, npm/openai@4.24.0, npm/resolve@1.22.3, npm/rfdc@1.3.0, npm/serve-handler@6.1.5, npm/serve@14.2.1, npm/ts-jest@29.1.1

View full report↗︎

@abretonc7s abretonc7s changed the title Remove i18next feat(sdk): remove i18next dependency Nov 21, 2024
@ecp4224 ecp4224 changed the base branch from main to edkek/remove-react-workingdemo November 21, 2024 02:17
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/puppeteer@23.8.0 ⚠︎

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/puppeteer@23.8.0

@ecp4224 ecp4224 force-pushed the edkek/remove-react-workingdemo branch from b49701b to b73b246 Compare November 21, 2024 03:05
Base automatically changed from edkek/remove-react-workingdemo to main November 21, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant